Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix description of log instrumentation #6236

Merged
merged 5 commits into from
Feb 7, 2025
Merged

fix description of log instrumentation #6236

merged 5 commits into from
Feb 7, 2025

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Feb 6, 2025

Fixes #6093
Update to the correct description for Log instrumentation.

@maryliag maryliag requested a review from a team as a code owner February 6, 2025 18:12
@opentelemetrybot opentelemetrybot requested review from a team February 6, 2025 18:12
chalin
chalin reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See inline comment.

content/en/docs/languages/java/instrumentation.md Outdated Show resolved Hide resolved
chalin
chalin reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, better! See inline for further suggested improvements -- let's drop the colons to make the reading flow better.

content/en/docs/languages/java/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/java/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/java/instrumentation.md Outdated Show resolved Hide resolved
content/en/docs/languages/java/instrumentation.md Outdated Show resolved Hide resolved
@maryliag
Copy link
Contributor Author

maryliag commented Feb 7, 2025

done!

trask
trask approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @maryliag!

chalin
chalin approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@chalin chalin merged commit 5c00724 into main Feb 7, 2025
20 checks passed
@chalin chalin deleted the fix-log-desc-en branch February 7, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
sig:java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect description of Log Instrumentation
3 participants
@maryliag @trask @chalin