Update 'rv' value generation based on randomness flag + editorial changes to improve clarity #261
Conversation
kalyanaj
changed the title
kalyanaj
changed the title
|
We don't typically update OTEPs with any substantial content. Minor editorial changes are fine, but otherwise normally a new OTEP is expected. |
|
Hi @tigrannajaryan, to give you some context, while the diff looks bigger, there is no change to the proposal or approach itself, so from that perspective there are no changes (substantial or otherwise). This PR is an effort to improve the clarity and change the flow/wording (based on a discussion in the Sampling SIG) to improve the readability for future implementers of this spec. |
|
Suggestion from Kent: please try to minimize diffs by keeping to one sentence per line of markdown. |
|
@kalyanaj now that I've read this PR in detail, I agree with @tigrannajaryan's suggestion. This PR is difficult to review because of all the editorial changes, which I also appreciate. I think it would be easiest if we open a new PR with a completely new document, with a new OTEP number. Then, update the OTEP 235 document to refer to the new OTEP, along with an explanation of the non-editorial changes relative to 235. In my words, the only change here is to say:
I see this change as a bug fix, but it is still a change. I think readers will be happy to read the edited document either way, but leaving OTEP 235 "as-is" may be easiest here. Thanks! |
jmacd
changed the title
|
I have copied the bulk of this PR into open-telemetry/opentelemetry-specification#4166. |
|
We should merge this, just need approvals. The language in this PR is already incorporated into the spec PRs, no reason not to merge. |
| @@ -80,23 +102,54 @@ The `T` value MUST be derived as follows: | |||
|
|
|||
| Sampling Decisions MUST be propagated by setting the value of the `th` key in the Tracestate header according to the above. | |||
|
|
|||
| ## Initializing and updating T and R values | |||
| This design requires that as a given span progresses along its collection path, `th` is non decreasing (and, in particular, must be increased at stages that apply lower sampling probabilities). | |||
There was a problem hiding this comment.
This paragraph and the next one seem to imply that increasing T/th is fine, but decreasing it is not, whereas the Head Samplers sections puts this as an actual example.
Update 'r' value generation based on randomness flag + editorial changes to improve clarity.