Skip to content

Conversation

kkoehn
Copy link
Contributor

@kkoehn kkoehn commented Aug 28, 2025

We should consider the following points:

  • Migration of native_files to ActiveStorage
  • Removal of native_file column
  • I removed CodeOcean::File#hash_content since I don't think it was used. If it is indeed unused, the column could be removed as well

@kkoehn kkoehn self-assigned this Aug 28, 2025
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.13%. Comparing base (d248f40) to head (f688624).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
app/controllers/code_ocean/files_controller.rb 50.00% 3 Missing ⚠️
app/models/code_ocean/file.rb 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3099      +/-   ##
==========================================
- Coverage   70.24%   70.13%   -0.12%     
==========================================
  Files         215      214       -1     
  Lines        6850     6833      -17     
==========================================
- Hits         4812     4792      -20     
- Misses       2038     2041       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kkoehn kkoehn force-pushed the migrate_carrierwave_to_activestorage branch 3 times, most recently from 0100bcf to 54c0cd0 Compare September 5, 2025 21:03
@kkoehn kkoehn force-pushed the migrate_carrierwave_to_activestorage branch from 54c0cd0 to ccf63fe Compare September 6, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant