feat(core:domain): Migrate to KMP #2350
Conversation
core/domain/build.gradle.kts
Outdated
| @@ -8,37 +8,67 @@ | |||
| * See https://github.com/openMF/android-client/blob/master/LICENSE.md | |||
| */ | |||
| plugins { | |||
| alias(libs.plugins.mifos.android.library) | |||
| alias(libs.plugins.mifos.kmp.library) | |||
| alias(libs.plugins.mifos.android.library.jacoco) | |||
| alias(libs.plugins.mifos.android.koin) | |||
There was a problem hiding this comment.
this is for android. Remove this and include alias(libs.plugins.mifos.kmp.koin)
There was a problem hiding this comment.
Implemented the suggestion. Thanks
| alias(libs.plugins.jetbrainsCompose) | ||
| alias(libs.plugins.compose.compiler) |
There was a problem hiding this comment.
Those are added for the following code in build.gradle of core:domain:
compose.resources {
publicResClass = true
generateResClass = always
packageOfResClass = "core.domain.generated.resources"
}
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
| ): Flow<Resource<GenericResponse>> = callbackFlow { | ||
| ): Flow<Resource<GenericResponse>> = flow { | ||
| try { | ||
| trySend(Resource.Loading()) | ||
| emit(Resource.Loading()) | ||
| val response = activateRepository.activateGroup(groupId, groupPayload) | ||
| trySend(Resource.Success(response)) | ||
| emit(Resource.Success(response)) | ||
| } catch (exception: Exception) { | ||
| send(Resource.Error(exception.message.toString())) | ||
| emit(Resource.Error(exception.message.toString())) | ||
| } | ||
| } |
There was a problem hiding this comment.
@biplab1 don't use try-catch inside flow. Take reference from LoginUseCase
There was a problem hiding this comment.
I will look into it. Thanks.
There was a problem hiding this comment.
I have implemented your suggestion.
# Conflicts: # core/domain/src/commonMain/kotlin/com/mifos/core/domain/useCases/DeleteClientAddressPinpointUseCase.kt # core/domain/src/main/java/com/mifos/core/domain/useCases/GetAllLoanUseCase.kt
| try { | ||
| emit(Resource.Loading()) | ||
| emit(Resource.Loading()) | ||
| }.flatMapLatest { | ||
| repository.getCentersGroupAndMeeting(centerId) |
There was a problem hiding this comment.
when return type is flow, i dont think we need useCases, use it directly in the viewmodel
There was a problem hiding this comment.
We are returning flow in every useCases. I don't think I understand your statement. Could you please elaborate?
There was a problem hiding this comment.
@biplab1 since repository.getCentersGroupAndMeeting(centerId) already returns flow, we do not need to convert it to flow again.
There was a problem hiding this comment.
I understand your point now. Thanks
There was a problem hiding this comment.
Here we are combining two flows into a single flow using zip
# Conflicts: # core/domain/src/androidMain/kotlin/com/mifos/core/domain/useCases/GroupsListPagingDataSource.android.kt
|
|
||
| operator fun invoke(): Flow<Resource<SavingProductsAndTemplate?>> = | ||
| flow { | ||
| try { | ||
| emit(Resource.Loading()) | ||
|
|
||
| val savingProductsAndTemplate = coroutineScope { | ||
| val savingsAccount = async { repository.savingsAccounts() } | ||
| val template = async { repository.savingsAccountTemplate() } | ||
|
|
||
| SavingsProductsAndTemplate( | ||
| savingsAccount = savingsAccount.await(), | ||
| template = template.await(), | ||
| ) | ||
| } | ||
| emit(Resource.Success(savingProductsAndTemplate)) |
There was a problem hiding this comment.
I will look into it. Thanks
There was a problem hiding this comment.
I have implemented your suggestion. Thanks again
Fixes - Jira-#410
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.