Skip to content

Conversation

@JaySoni1
Copy link
Contributor

@JaySoni1 JaySoni1 commented Oct 5, 2025

Replaced custom methods in *.ts files that were previously using ShareService with their corresponding auto-generated methods from the OpenAPI-based @fineract/client package.

@coderabbitai
Copy link

coderabbitai bot commented Oct 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@JaySoni1
Copy link
Contributor Author

JaySoni1 commented Oct 5, 2025

@gkbishnoi07 Please Review .

@gkbishnoi07
Copy link
Collaborator

@gkbishnoi07 Please Review .

on it!

@steinwinde
Copy link
Collaborator

@gkbishnoi07 , are you still reviewing? Or can this be merged?

@gkbishnoi07
Copy link
Collaborator

@gkbishnoi07 , are you still reviewing? Or can this be merged?

I need your help in this i didn't get where to test it! I mean where I will find the share functionality
Can you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants