feat(frontend): add Machine Edit UI/API, empty data/admin.py - #444
Merged
Conversation
Ports MachineAdminForm's cross-field validation into Machine.clean(), and replicates the admin's conditional VIRTUALIZATION SERVER/CLIENT fieldset visibility. Drops the redundant FQDN-uniqueness form check. This is the last Django Admin registration in orthos2/data; admin.py is now empty of model registrations. Also fixes a stray "group_id" leftover in MachineAPIForm.get_order(). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
SchoolGuy
force-pushed
the
feature/obsolete-django-admin-machine
branch
from
August 21, 2026 09:27
e5d7420 to
dc52962
Compare
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 2 high |
🟢 Metrics 15 complexity · 52 duplication
Metric Results Complexity 15 Duplication 52
🟢 Coverage 92.64% diff coverage · +0.33% coverage variation
Metric Results Coverage variation ✅ +0.33% coverage variation (-1.00%) Diff coverage ✅ 92.64% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (a9d9d98) 22890 16948 74.04% Head commit (dc52962) 23012 (+122) 17115 (+167) 74.37% (+0.33%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#444) 258 239 92.64% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports MachineAdminForm's cross-field validation into Machine.clean(), and replicates the admin's conditional VIRTUALIZATION SERVER/CLIENT fieldset visibility. Drops the redundant FQDN-uniqueness form check. This is the last Django Admin registration in orthos2/data; admin.py is now empty of model registrations. Also fixes a stray "group_id" leftover in MachineAPIForm.get_order().