Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]: Change env CHROMA_IN_MEMORY's type from str to bool before use it #402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zanghu
Copy link

@zanghu zanghu commented Dec 26, 2023

Short Description*: In chroma_datastore.py, the os.getenv function returns the value of the CHROMA_IN_MEMORY environment variable as a string. Currently, in the ChromaDataStore.__init__ method (specifically, the in_memory variable), it directly relies on this value for decision-making(e.g.: if in_memory: ...). However, since any non-empty string is evaluated as True in the if statement, it results in the program attempting to use in_memory storage even when the CHROMA_IN_MEMORY environment variable is set to "false".

Issue(s) Linked: #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants