Skip to content

Remove unecessary pending client tool call cleanup on message/thread creation #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilkes-oai merged 2 commits into from
Jan 5, 2026
Merged

Remove unecessary pending client tool call cleanup on message/thread creation #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16fa7ec
Remove unecessary pending client tool call cleanup on message/thread …
wilkes-oai Jan 5, 2026
8ebc64d
remove test
wilkes-oai Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion chatkit/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,6 @@ async def _process_new_thread_item_respond(
context: TContext,
) -> AsyncIterator[ThreadStreamEvent]:
await self.store.add_thread_item(thread.id, item, context=context)
await self._cleanup_pending_client_tool_call(thread, context)
yield ThreadItemDoneEvent(item=item)

async for event in self._process_events(
Expand Down
67 changes: 0 additions & 67 deletions tests/test_chatkit_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,73 +679,6 @@ async def responder(
assert events[1].type == "thread.item.done"
assert events[1].item.type == "assistant_message"


async def test_removes_tool_call_if_no_output_provided():
async def responder(
thread: ThreadMetadata, input: UserMessageItem | None, context: Any
) -> AsyncIterator[ThreadStreamEvent]:
assert isinstance(input, UserMessageItem)
assert input.content[0].type == "input_text"
if input.content[0].text == "Message 1":
yield ThreadItemDoneEvent(
item=ClientToolCallItem(
id="msg_1",
created_at=datetime.now(),
name="tool_call_1",
arguments={"arg1": "val1", "arg2": False},
call_id="tool_call_1",
thread_id=thread.id,
),
)
else:
yield ThreadItemDoneEvent(
item=AssistantMessageItem(
id="msg_2",
content=[AssistantMessageContent(text="All done!")],
created_at=datetime.now(),
thread_id=thread.id,
),
)

with make_server(responder) as server:
events = await server.process_streaming(
ThreadsCreateReq(
params=ThreadCreateParams(
input=UserMessageInput(
content=[UserMessageTextContent(text="Message 1")],
attachments=[],
inference_options=InferenceOptions(),
)
)
)
)
thread = next(
event.thread for event in events if event.type == "thread.created"
)

await server.process_streaming(
ThreadsAddUserMessageReq(
params=ThreadAddUserMessageParams(
thread_id=thread.id,
input=UserMessageInput(
content=[UserMessageTextContent(text="Message 2")],
attachments=[],
inference_options=InferenceOptions(),
),
)
)
)

items_result = await server.process_non_streaming(
ItemsListReq(params=ItemsListParams(thread_id=thread.id))
)
items = TypeAdapter(Page[ThreadItem]).validate_json(items_result.json)
assert len(items.data) == 3
assert items.data[0].type == "assistant_message"
assert items.data[1].type == "user_message"
assert items.data[2].type == "user_message"


async def test_respond_with_tool_status():
async def responder(
thread: ThreadMetadata, input: UserMessageItem | None, context: Any
Expand Down