Skip to content

fix(errors): redact supported provider API keys #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sylvesterkaczmarek wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −1
Open

fix(errors): redact supported provider API keys #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cafbc5
fix(errors): redact Linear API keys
sylvesterkaczmarek Aug 18, 2026
fff254c
test(errors): cover Linear API keys
sylvesterkaczmarek Aug 18, 2026
7c71b54
fix(errors): redact Fireworks API keys
sylvesterkaczmarek Aug 18, 2026
0051de9
test(errors): cover Fireworks API-key prefix
sylvesterkaczmarek Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/typescript/src/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export function errorMessage(error: unknown): string {
export function safeErrorMessage(error: unknown): string {
const message = errorMessage(error);
const recognizableCredential =
/(?:\b(?:sk-(?:proj-)?|github_pat_|gh[pousr]_|npm_)\S+|\b(?:bearer|basic|token)(?:\s|%20|\+)+\S+|:\/\/[^\s/@]+@|-----BEGIN [A-Z ]*PRIVATE KEY(?: BLOCK)?-----)/iu.test(
/(?:\b(?:sk-(?:proj-)?|github_pat_|gh[pousr]_|npm_|lin_api_|fw_)\S+|\b(?:bearer|basic|token)(?:\s|%20|\+)+\S+|:\/\/[^\s/@]+@|-----BEGIN [A-Z ]*PRIVATE KEY(?: BLOCK)?-----)/iu.test(
message,
);
const assignments = message.matchAll(
Expand Down
2 changes: 2 additions & 0 deletions sdk/typescript/tests-ts/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ describe("error messages", () => {
for (const message of [
"request failed: token=SYNTHETIC_TOKEN",
"Authorization: Bearer sk-proj-SYNTHETIC_KEY_123",
"Linear failed for lin_api_SYNTHETIC_SECRET",
"Fireworks failed for fw_SYNTHETIC_SECRET",
'upstream failed: {"clientSecret":"correct horse battery staple"}',
JSON.stringify(JSON.stringify({ clientSecret: "SYNTHETIC_SECRET" })),
"authorizationHeaderValue=SYNTHETIC_SECRET",
Expand Down