fix(progress): ignore code-fenced status markers - #526
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
fix(progress): ignore code-fenced status markers#526sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep Markdown examples and quoted code from being reported as live scan progress or worker dispatch state.
Fixes #525.
Problem
Progress parsing currently toggles a single boolean for every line beginning with three backticks. A valid four-backtick outer fence can therefore be closed incorrectly by a shorter three-backtick run inside it, exposing a quoted progress marker as live state.
Worker-status parsing has no fence handling at all, so a marker inside an ordinary fenced example is accepted directly.
Changes
Validation
The branch is based on current upstream
main(99c85613b0c4b8202b33dfbd80f41884fb9eac11) and is not behind it. Full repository tests cannot be run in this execution environment because the repository cannot be cloned here; pushed-head CI remains required.Risk
Low. JSON marker validation is unchanged. The change only removes marker-looking lines while they are inside Markdown fenced code blocks.