fix(progress): reject inconsistent preflight capability output - #554
Open
sylvesterkaczmarek wants to merge 4 commits into
Open
fix(progress): reject inconsistent preflight capability output#554sylvesterkaczmarek wants to merge 4 commits into
sylvesterkaczmarek wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not report worker delegation/capacity from
config_preflight.pyexecution metadata that is explicitly failed or inconsistent with the helper's own evaluated status.Fixes #553.
Reproduction / evidence
Current upstream
mainat37bf87a692fc72d41f7312cc48808d699d204fbaparses capability JSON whenever anitem.completedcommand matchesconfig_preflight.py, without reconciling the command execution metadata with the helper result.A command item marked
status: "failed"can therefore carry otherwise valid-lookingstatus: "ready"capability JSON and still be reported as:The helper has deliberate exit semantics that must be preserved:
readyexits 0,blockedexits 1, andincompleteexits 2.Root cause
preflightStatus()validated the command name and JSON structure but treated execution status, exit code and top-level helper status as unrelated fields.Fix
ready0,blocked1,incomplete2);Tests / validation
worker-preflight-failure.test.tscovers:The branch is based directly on current upstream
mainat37bf87a692fc72d41f7312cc48808d699d204fbaand is not behind it.Full repository tests cannot be run in this execution environment because the repository cannot be cloned here. Pushed-head CI remains the authoritative full-suite validation.
Risk
Low. The parser now checks consistency rather than treating every nonzero exit as failure, so valid blocked/incomplete capability evidence remains visible.