-
Notifications
You must be signed in to change notification settings - Fork 717
fix: explain scan sign-in refresh failures #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mldangelo-oai
wants to merge
7
commits into
main
Choose a base branch
from
mdangelo/codex/fix-scan-auth-recovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−5
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6470182
fix: explain scan sign-in refresh failures
mldangelo-oai 319a649
fix: preserve credential-specific recovery advice
mldangelo-oai b896475
refactor: leave native auth recovery to Codex
mldangelo-oai 79d3382
refactor: simplify scan sign-in recovery
mldangelo-oai 8a56a0b
Merge remote-tracking branch 'origin/main' into mdangelo/codex/fix-sc…
mldangelo-oai 56a5df4
Merge branch 'main' into mdangelo/codex/fix-scan-auth-recovery
mldangelo-oai 7c3a3ae
Merge remote-tracking branch 'origin/main' into HEAD
mldangelo-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When either alternate refresh message covered by the new test (
because you have since logged out...orauthentication session could not be refreshed automatically) arrives with trailing upstream detail, this regex misses it, classification remainsunknown, anddiagnosticValueemits the entire wrapper to stderr. That permits organization, project, or credential-bearing suffixes to escape through the same boundary this branch sanitizes for the four permanent variants; preserve the native recovery advice by extracting/replacing the complete upstream error rather than passing the wrapper through.AGENTS.md reference: sdk/typescript/AGENTS.md:L8-L12
Useful? React with 👍 / 👎.