fix(scan): allow large git output during scan prep - #572
Open
sylvesterkaczmarek wants to merge 3 commits into
Open
fix(scan): allow large git output during scan prep#572sylvesterkaczmarek wants to merge 3 commits into
sylvesterkaczmarek wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow committed-diff scan preparation to handle repositories whose tracked-file inventory exceeds Node's default
execFilestdout buffer.validateCommittedDiffCheckout()runsgit ls-files -t -zto detect sparse checkouts. On large repositories, that output can exceed Node's default 1 MiB buffer and terminate scan preparation withERR_CHILD_PROCESS_STDIO_MAXBUFFERbefore scanning begins.Fixes #565.
Changes
maxBuffer: Infinity, matching the unbounded subprocess-buffer convention already used elsewhere in this packageTesting
git ls-files -t -zoutput and verifies committed-diff validation completesmain; the diff is limited to one production line insrc/targets.tsand the regression fileRisk and rollout
Low. Git command output was already collected in memory; this removes Node's default rejection threshold rather than changing the command, output format, or validation behavior. The change follows the same
maxBuffer: Infinityconvention already present in the SDK runtime and avoids introducing an arbitrary repository-size limit.Public disclosure review