Skip to content

path-uri: remove legacy path deserialization#29158

Merged
anp-oai merged 3 commits into
mainfrom
codex/path-uri-uri-only-deserialization
Jun 23, 2026
Merged

path-uri: remove legacy path deserialization#29158
anp-oai merged 3 commits into
mainfrom
codex/path-uri-uri-only-deserialization

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Why

I'd originally added PathUri legacy path deserialization thinking we'd want it for having PathUri in public app-server APIs. Since then we've added LegacyAppPathString to handle the messy conversions that we need for backcompat. It's confusing for PathUri to support deserializing legacy paths when we don't yet want to actually expose app-server callers or rollout storage to the new URI format.

Stacked on top of #29472 to avoid breaking compatibility in case those types ended up stored somewhere for someone.

What changed

  • Parse deserialized PathUri values exclusively as valid file: URIs.
  • Replace legacy acceptance coverage with rejection coverage for top-level filesystem paths and sandbox working directories.
  • Serialize CWDs in hand-built exec-server process requests as PathUri values.

anp-oai added a commit that referenced this pull request Jun 20, 2026
@anp-oai anp-oai marked this pull request as ready for review June 22, 2026 17:32
@anp-oai anp-oai requested a review from a team as a code owner June 22, 2026 17:32
anp-oai added a commit that referenced this pull request Jun 22, 2026
@anp-oai anp-oai force-pushed the codex/path-uri-uri-only-deserialization branch from 24cad50 to 9d8c811 Compare June 22, 2026 17:32
@anp-oai

anp-oai commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9d8c81141f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/utils/path-uri/src/lib.rs
Comment thread codex-rs/utils/path-uri/src/lib.rs
anp-oai added a commit that referenced this pull request Jun 22, 2026
@anp-oai anp-oai force-pushed the codex/path-uri-uri-only-deserialization branch from d6e29c9 to 43659bc Compare June 22, 2026 19:25
@anp-oai anp-oai changed the base branch from main to codex/legacy-exec-event-cwd June 22, 2026 19:26
@anp-oai anp-oai force-pushed the codex/legacy-exec-event-cwd branch 4 times, most recently from f7d5959 to 2233689 Compare June 23, 2026 01:46
anp-oai added a commit that referenced this pull request Jun 23, 2026
@anp-oai anp-oai force-pushed the codex/path-uri-uri-only-deserialization branch from 43659bc to f832435 Compare June 23, 2026 21:03
@anp-oai anp-oai changed the base branch from codex/legacy-exec-event-cwd to main June 23, 2026 21:03
@anp-oai

anp-oai commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: f832435bda

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@anp-oai anp-oai force-pushed the codex/path-uri-uri-only-deserialization branch from f832435 to 0aca7ac Compare June 23, 2026 21:32
@anp-oai anp-oai enabled auto-merge (squash) June 23, 2026 21:32
@anp-oai anp-oai merged commit c26f961 into main Jun 23, 2026
31 checks passed
@anp-oai anp-oai deleted the codex/path-uri-uri-only-deserialization branch June 23, 2026 21:47
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants