path-uri: remove legacy path deserialization#29158
Conversation
24cad50 to
9d8c811
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d8c81141f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d6e29c9 to
43659bc
Compare
f7d5959 to
2233689
Compare
43659bc to
f832435
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
f832435 to
0aca7ac
Compare
Why
I'd originally added
PathUrilegacy path deserialization thinking we'd want it for havingPathUriin public app-server APIs. Since then we've addedLegacyAppPathStringto handle the messy conversions that we need for backcompat. It's confusing forPathUrito support deserializing legacy paths when we don't yet want to actually expose app-server callers or rollout storage to the new URI format.Stacked on top of #29472 to avoid breaking compatibility in case those types ended up stored somewhere for someone.
What changed
PathUrivalues exclusively as validfile:URIs.PathUrivalues.