code-mode: type cells by execution capability#29400
Closed
cconger wants to merge 1 commit into
Closed
Conversation
cconger
force-pushed
the
cconger/code-mode-runtime-compact-03f2-cell-capabilities
branch
from
55dad2b to
d9bc7ff
Compare
cconger
force-pushed
the
cconger/code-mode-runtime-compact-03f1-pending-generations
branch
from
b140ec7 to
8eac740
Compare
This was referenced Jun 22, 2026
jif-oai
approved these changes
Jun 22, 2026
jif-oai
left a comment
jif-oai
left a comment
Collaborator
There was a problem hiding this comment.
Pre-approving because it's nit
| /// Selects the next observable frontier for a running cell. | ||
| /// A cell that continues whenever external input unblocks its runtime. | ||
| #[derive(Clone, Debug, Eq, Hash, PartialEq)] | ||
| pub(crate) struct Cell { |
Collaborator
There was a problem hiding this comment.
Can we bind these handles to their originating SessionRuntime, or carry/check a runtime token?
| @@ -184,10 +220,14 @@ impl<D: SessionRuntimeDelegate> SessionRuntime<D> { | |||
|
|
|||
| async fn start_cell( | |||
Collaborator
There was a problem hiding this comment.
Can CellKind be the single source of truth and derive the actor policy from it? Here the args encode the same capability twice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Continuing execution and pause-at-frontier execution have different lifecycle contracts. Allowing callers to mix
wait,wait_to_pending, andresumeon one untyped handle makes invalid combinations possible and obscures whether pending states are observable.What
CellandPausableCellhandles.wait.wait_to_pendingand generation-checkedresume.Stack boundary
This is a Rust
SessionRuntimecapability split. The host/core protocol continues to expose only the continuing-cell path in this stack; pausable APIs remain a direct runtime API when the runtime becomes public in #29292.Validation
just test -p codex-code-modeStack parent: #29399.