Deny transport for local-only Git operations#29470
Draft
bookholt-oai wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some internal Git commands are intended to inspect only local repository state, but Git can implicitly fetch a missing object from a partial clone's promisor remote. A repository can select that remote and its transport helpers, so a passive diff or branch-summary lookup could cross a network/process boundary even though Codex did not issue an explicit fetch command.
What
/diffcommand wrappers.How
Local-only commands set
GIT_ALLOW_PROTOCOLto an empty allowlist, which prevents all Git protocols even when repository config allows a helper explicitly. They also setGIT_NO_LAZY_FETCH=1as defense in depth on newer Git versions. The TUI uses the same policy for workspace commands executed through either embedded or remote app-server sessions.Testing
just test -p codex-git-utils— 27 passed.just test -p codex-tui branch_summary::tests— 6 passed.just test -p codex-tui get_git_diff::tests— 7 passed.mainand were subsequently changed upstream; 4 skipped.just fix -p codex-git-utilsjust fix -p codex-tuijust fmt