Skip to content

[codex] handle request_user_input in app-server test client#29476

Merged
celia-oai merged 1 commit into
mainfrom
codex/app-server-test-client-user-input
Jun 22, 2026
Merged

[codex] handle request_user_input in app-server test client#29476
celia-oai merged 1 commit into
mainfrom
codex/app-server-test-client-user-input

Conversation

@celia-oai

Copy link
Copy Markdown
Collaborator

Why

codex-app-server-test-client previously treated item/tool/requestUserInput as an unsupported server request and terminated the connection. That made it impossible to use the client for end-to-end testing of interactive turns: an operator could observe the request, but could not answer it and confirm that the same turn resumed.

What changed

  • Handle ToolRequestUserInput server requests in the test client's central request dispatcher.
  • Render numbered terminal choices, accept exact option labels, support free-form Other and text-only questions, and collect multiple answers.
  • Send a protocol-native ToolRequestUserInputResponse and continue streaming the active turn.
  • Fail clearly when interactive input is requested without a terminal.
  • Document the interactive behavior and add focused tests for option selection, free-form answers, multiple questions, and invalid-selection retries.

Testing

  • just test -p codex-app-server-test-client
  • just bazel-lock-check
  • Manually exercised the app-server flow, selected TUI, observed serverRequest/resolved, and verified that the same turn completed with the selected answer.

@celia-oai celia-oai requested a review from aibrahim-oai June 22, 2026 20:53
@celia-oai celia-oai marked this pull request as ready for review June 22, 2026 20:53
@celia-oai celia-oai merged commit cb255c5 into main Jun 22, 2026
31 checks passed
@celia-oai celia-oai deleted the codex/app-server-test-client-user-input branch June 22, 2026 20:55
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants