codex: verify review collaborators independently - #31
Closed
ttaylorr-oai wants to merge 1 commit into
Closed
Conversation
The plan admission runner reads pull-request reviews with GITHUB_TOKEN. For organization members, GitHub can report author_association=NONE to that token even though a user token sees MEMBER. That makes a valid exact-head approval fail closed and blocks plan admission. Keep the exact-head and latest-review checks, but fall back to the repository collaborator endpoint when the association is not already trusted. The endpoint is repository-scoped and available with metadata:read; a 404 or API failure still rejects the review. Cover both the hidden-member success case and outsider rejection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan admission runner can see an organization-member approval as author_association=NONE when it uses GITHUB_TOKEN. Keep the exact-head and latest-review checks, then fall back to the repository collaborator endpoint before rejecting the reviewer. A missing collaborator or API failure still fails closed.
This unblocks the trusted admission path for PR #29 without weakening the review gate.
Tests: