codex: use writer reviews for hidden members - #33
Merged
Conversation
The repository collaborator fallback is also unavailable to the Actions token, so a valid organization-member approval still fails admission. Keep the REST fast path, but fall back to latestOpinionatedReviews with writersOnly when author_association is hidden. GitHub computes writer eligibility server-side, while the existing non-author, latest-state, and exact-head checks stay intact. Cover the hidden-association writer case and reject a non-writer.
friel-openai
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collaborator fallback from #30 is also unavailable to the Actions token. Keep the existing REST fast path, then fall back to GraphQL latestOpinionatedReviews(writersOnly:true) when author_association is hidden. GitHub computes writer eligibility server-side; the non-author, latest-state, and exact-head checks remain unchanged.
This is the follow-up needed for trusted admission of PR #32.
Tests: