fix: include JsonSchema definitions in mcpTool inputSchema #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 24b7f05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
seratch
requested changes
Jul 23, 2025
packages/agents-core/src/metadata.ts
Outdated
| @@ -3,11 +3,11 @@ | |||
|
|
|||
| export const METADATA = { | |||
There was a problem hiding this comment.
would it be possible to ask you to remove metadata.ts changes? Since the next release, these diff won't show up.
seratch
approved these changes
Jul 24, 2025
vrtnis
pushed a commit
to vrtnis/openai-agents-js
that referenced
this pull request
Jul 28, 2025
Co-authored-by: Kazuhiro Sera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the framework’s inputSchema parameter is expected to comply with JSON Schema standards. However, when the schema contains $ref references, the corresponding definitions were not being included. This caused incomplete schemas to be generated.
This PR fixes the issue by modifying a single line of code to ensure that all referenced JSON Schema definitions are properly included within the inputSchema.
This change improves schema completeness and compatibility with JSON Schema validators.