Fix: update error message #370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
reviewed
Aug 26, 2025
| }, | ||
| }); | ||
| throw new ModelBehaviorError('Invalid output type'); | ||
| throw new ModelBehaviorError(errorMessage); |
There was a problem hiding this comment.
Just replacing this way may not be helpful enough for developers. We need to check how the actual dev experience looks like.
There was a problem hiding this comment.
I think there will be only single error which will be related to JSON.parse which will be understandable.
|
This PR is stale because it has been open for 10 days with no activity. |
|
@seratch, let me know if you need me to pick this up. cc: @NiteshSingh17 |
|
This PR is stale because it has been open for 10 days with no activity. |
|
This PR was closed because it has been inactive for 7 days since being marked as stale. |
|
@seratch would it be helpful if I took a look at this issue and circled back with a new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #316