feat: #439 add SIP support for realtime agent runner #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0e2aefc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
@codex review |
seratch
force-pushed
the
issue-439-sip-support
branch
from
df817d3 to
e2246cb
Compare
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
seratch
force-pushed
the
issue-439-sip-support
branch
from
e2246cb to
f7f3e5f
Compare
Comment on lines
+125
to
+130
| session.transport.sendEvent({ | ||
| type: 'response.create', | ||
| response: { | ||
| instructions: `Say exactly '${WELCOME_MESSAGE}' now before continuing the conversation.`, | ||
| }, | ||
| }); |
dkundel-openai
approved these changes
Oct 31, 2025
seratch
commented
Oct 31, 2025
| | 'gpt-4o-mini-realtime-preview-2024-12-17' | ||
| | 'gpt-realtime' | ||
| | 'gpt-realtime-2025-08-28' | ||
| | 'gpt-realtime-mini' |
Member
Author
There was a problem hiding this comment.
unrelated but i've added these missing models too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #439; also, the change aligns with openai/openai-agents-python#1993