Skip to content

Conversation

pxkundu
Copy link

@pxkundu pxkundu commented Sep 20, 2025

Summary

Added comprehensive audio storage configuration for realtime sessions, addressing TODO comments in the codebase.

Test plan

  • All existing tests pass (769 tests)
  • Code follows project style guidelines (ruff, mypy)
  • New RealtimeAudioStorageConfig class with proper documentation

Issue number

Addresses TODO comments in src/agents/realtime/config.py and src/agents/realtime/session.py

Checks

  • I've added new tests (if relevant)
  • I've added/updated the relevant documentation
  • I've run make lint and make format
  • I've made sure tests pass

- Add RealtimeAudioStorageConfig class with comprehensive audio storage options
- Include configurable storage path, duration limits, format, compression, and retention
- Update RealtimeRunConfig to include audio_storage_config field
- Remove TODO comments and replace with proper implementation
- All tests passing and code properly formatted
@seratch seratch added enhancement New feature or request feature:realtime labels Sep 22, 2025
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check if this works later but if you could add some unit tests as well, it'd be greatly appreciated too

print("[debug] get_weather called")
return Weather(city=city, temperature_range="14-20C", conditions="Sunny with wind.")


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Comment on lines +515 to 516
# Audio storage config is now available in RealtimeRunConfig.audio_storage_config

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Audio storage config is now available in RealtimeRunConfig.audio_storage_config

@seratch seratch requested a review from rm-openai September 22, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature:realtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants