feat: add MCP Resources support #2060
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [tool.uv.workspace] | ||
| members = ["agents"] | ||
| members = [ | ||
| "agents", | ||
| "checking", | ||
| ] |
There was a problem hiding this comment.
checking
Adding "checking" to tool.uv.workspace.members introduces a build-time failure because the repository contains no checking/ package. Running uv or make commands now causes uv to error with “No such workspace member ‘checking’”, preventing dependency installs or packaging. This looks unrelated to the MCP resources feature and should be reverted or the directory added.
Useful? React with 👍 / 👎.
| """Invoke a tool on the server.""" | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| async def list_resources(self)-> ListResourcesResult: | ||
| """List resources available on the server.""" | ||
| pass | ||
| @abc.abstractmethod | ||
| async def read_resource(self, uri:str)-> ReadResourceResult: | ||
| """Read the content of a resource by URI.""" | ||
| pass | ||
| @abc.abstractmethod | ||
| async def subscribe_resource(self, uri:str, **kwargs) -> AsyncIterator[SessionMessage]: | ||
| """Subscribe to resource updates.""" | ||
| pass |
There was a problem hiding this comment.
Introducing list_resources, read_resource, and subscribe_resource as abstract methods on MCPServer means every existing subclass must implement them. Classes like tests/mcp/test_prompt_server.FakeMCPPromptServer (and any user-defined servers) still lack these methods, so instantiating them now raises TypeError: Can't instantiate abstract class … and the current test suite will fail. Consider providing default implementations or updating all subclasses.
Useful? React with 👍 / 👎.
|
Thanks for sending this patch. However, we don't plan to add these methods for now because the core part of this SDK does not use MCP resources at all. |
2 participants
Summary
Adds MCP Resources support (list, read, subscribe) to complete protocol implementation.
Changes
list_resources()- discover available resourcesread_resource(uri)- read resource contentsubscribe_resource(uri)- stream resource updatesResources enable agents to access files, databases, and data streams per the MCP spec.
Details
Happy to add tests or docs if needed!