-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add logprobs to ModelSettings #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zain
wants to merge
7
commits into
openai:main
Choose a base branch
from
zain:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−4
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
41c2ffb
Add logprobs support for responses
zain e5cf75c
Merge pull request #1 from zain/codex/add-support-for-logprobs-in-age…
zain 800baee
revert docs changes as requested
zain 9aae7d1
add top_logprobs to chatcompletions and litellm
zain e0fa083
revert other docs change
zain 834042e
remove newline
zain df5e647
Merge branch 'main' into main
zain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import pytest | ||
from openai.types.responses.response_usage import InputTokensDetails, OutputTokensDetails | ||
|
||
from agents import ModelSettings, ModelTracing, OpenAIResponsesModel | ||
|
||
|
||
class DummyResponses: | ||
async def create(self, **kwargs): | ||
self.kwargs = kwargs | ||
|
||
class DummyResponse: | ||
id = "dummy" | ||
output = [] | ||
usage = type( | ||
"Usage", | ||
(), | ||
{ | ||
"input_tokens": 0, | ||
"output_tokens": 0, | ||
"total_tokens": 0, | ||
"input_tokens_details": InputTokensDetails(cached_tokens=0), | ||
"output_tokens_details": OutputTokensDetails(reasoning_tokens=0), | ||
}, | ||
)() | ||
|
||
return DummyResponse() | ||
|
||
|
||
class DummyClient: | ||
def __init__(self): | ||
self.responses = DummyResponses() | ||
|
||
|
||
@pytest.mark.allow_call_model_methods | ||
@pytest.mark.asyncio | ||
async def test_top_logprobs_param_passed(): | ||
client = DummyClient() | ||
model = OpenAIResponsesModel(model="gpt-4", openai_client=client) # type: ignore | ||
await model.get_response( | ||
system_instructions=None, | ||
input="hi", | ||
model_settings=ModelSettings(top_logprobs=2), | ||
tools=[], | ||
output_schema=None, | ||
handoffs=[], | ||
tracing=ModelTracing.DISABLED, | ||
previous_response_id=None, | ||
) | ||
assert client.responses.kwargs["top_logprobs"] == 2 | ||
assert "message.output_text.logprobs" in client.responses.kwargs["include"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.