Skip to content

Fix: Replace U+201C(“) and U+201D(”) with U+0022(") in XML and JSON #1774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Replace U+201C(“) and U+201D(”) with U+0022(") in XML and JSON #1774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b561209
Fix: Replace U+201C(“) and U+201D(”) with U+0022(") in XML and JSON
Benshi Apr 15, 2025
0cce294
Merge branch 'main' into patch-1
Benshi Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions examples/gpt4-1_prompting_guide.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,11 +577,11 @@
"Guidance specifically for adding a large number of documents or files to input context:\n",
"\n",
"* XML performed well in our long context testing. \n",
" * Example: `<doc id=1 title=”The Fox”>The quick brown fox jumps over the lazy dog</doc>` \n",
" * Example: `<doc id="1" title="The Fox">The quick brown fox jumps over the lazy dog</doc>` \n",
"* This format, proposed by Lee et al. ([ref](https://arxiv.org/pdf/2406.13121)), also performed well in our long context testing. \n",
" * Example: `ID: 1 | TITLE: The Fox | CONTENT: The quick brown fox jumps over the lazy dog` \n",
"* JSON performed particularly poorly.\n",
" * Example: `[{“id”: 1, “title”: “The Fox”, “content”: “The quick brown fox jumped over the lazy dog”}]`\n",
"* JSON performed particularly poorly. \n",
" * Example: `[{"id": 1, "title": "The Fox", "content": "The quick brown fox jumped over the lazy dog"}]`\n",
"\n",
"The model is trained to robustly understand structure in a variety of formats. Generally, use your judgement and think about what will provide clear information and “stand out” to the model. For example, if you’re retrieving documents that contain lots of XML, an XML-based delimiter will likely be less effective. \n",
"\n",
Expand Down