Improve disposal logic in AsyncWebsocketMessageResultEnumerator to prevent multiple disposals #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…event multiple disposals (openai#476) * Improve disposal logic in AsyncWebsocketMessageResultEnumerator to prevent multiple disposals * fb * Update src/Custom/RealtimeConversation/Internal/AsyncWebsocketMessageEnumerator.cs Co-authored-by: Stephen Toub <[email protected]> --------- Co-authored-by: Stephen Toub <[email protected]>
jsquire
requested review from
joseharriaga,
trrwilson and
ShivangiReja
as code owners
|
//cc: @christothes |
jsquire
commented
Jul 10, 2025
src/Custom/Realtime/Internal/AsyncWebsocketMessageEnumerator.cs
Outdated
Show resolved
Hide resolved
ShivangiReja
approved these changes
Jul 10, 2025
jsquire
commented
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of this change is to reapply the logic from #476 that got inadvertently stomped during the last upstream sync.