Skip to content

fix(client): allow withOptions to modify credentials #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TomerAberbach merged 2 commits into from
Jan 9, 2026
Merged

fix(client): allow withOptions to modify credentials #674

TomerAberbach merged 2 commits into from
Jan 9, 2026
+3 −3

Conversation

@FanYaning
Copy link
Contributor

@FanYaning FanYaning commented Jan 5, 2026 •
edited by TomerAberbach
Loading

Closes #661

@FanYaning FanYaning requested a review from a team as a code owner January 5, 2026 07:59
@FanYaning FanYaning changed the title fix code format Fix: The withOptions method of OpenAIClientImpl cannot modify authentication credentials Jan 5, 2026
@FanYaning FanYaning mentioned this pull request Jan 5, 2026
Closed
@TomerAberbach TomerAberbach changed the title Fix: The withOptions method of OpenAIClientImpl cannot modify authentication credentials fix(client): allow withOptions to modify credentials Jan 5, 2026
@TomerAberbach TomerAberbach merged commit 1d5a8f9 into openai:main Jan 9, 2026
4 of 5 checks passed
@stainless-app stainless-app bot mentioned this pull request Jan 9, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The withOptions method cannot modify authentication credentials.

2 participants

@FanYaning @TomerAberbach