fix(types): make id optional in ResponseFunctionToolCallParam #2249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Collaborator
|
Thanks for the PR! This has since been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses Issue #2205 by updating the
ResponseFunctionToolCallParamtype. Previously, theidfield was defined as a required string, but this change makes it optional, aligning the type definition with the actual usage scenarios.Changes Introduced:
src/openai/types/responses/response_function_tool_call_param.pyto change theidfield fromstrtoOptional[str].Rationale:
The GitHub issue details confirm that making id optional aligns with the API spec. Users have successfully tested the functionality without supplying an id, which further validates this change. This update improves the type accuracy and usability of the library.