Tests & DX: expand Image coverage (content_filter_results), dedupe retries/timeouts (sync+async); docs & typing polish #2616
+189
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR overlaps with #2615 / #2616.
If those land first, I’m happy to close this one.
The goal here is simply to improve async timeout/retry coverage and clarify per-request overrides.
Images: add tests for optional content_filter_results in image responses, asserting presence/absence handling and type safety.
Retries/Timeouts: deduplicate suites across sync/async; introduce conftest with fake OPENAI_API_KEY; clarify per-request timeout override vs client default; honor Retry-After.
Docs: README example updated to client.responses.create(...) (modern API).
Typing: openai/types/image.py imports (Dict, Any) to support optional fields; no runtime behavior change.
Chore: snapshot before archive.