Add gpt-4.1 to model #396
Open
Add gpt-4.1 to model #396
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yes we are getting errors with the new model since tiktoken is not up to date. currently spoofing with |
ayushanand13
approved these changes
Apr 21, 2025
gcovap
approved these changes
Apr 23, 2025
|
kindly pinging @hauntsaninja here |
|
Really looking forward to seeing this move forward! Thanks for the effort! |
|
Yes, looking forward to this PR to be merged for our use of gpt4.1. Thanks for creating the PR! |
4 tasks
|
Would really like to see this merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested gpt-4o and gpt-4.1 in the playground, and they seemed to use the same tokenizer because of the token count.