v0.7.2 #1433
Open
v0.7.2 #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Bit) in setup routines (#1429) * Remove redundant pip install for bullseye support pIp is also installed by openaps-packages.sh * Change python default to python2, install pip, pip install numpy for bullseye support * Bullseye support on arm64 (Raspberry Pi OS 64bit) Handle aarch64 architecture properly when downloading golang binaries. Without this setup will fail on Rpi 3/4/Zero2 devices where the user has installed the recently-released 64bit OS. Co-authored-by: Dave Acklam <[email protected]>
…#1419) * fix: Remove edison nodesource installation * fix: npm upgrade to latest *compatible* version, not the literal latest The previous command (which installs npm@latest) results in the installation of a version of npm which is almost certainly incompatible with the installed (regardless of source) version of nodejs * fix: Use n instead of apt for installing node & npm * fix: Improve node execution time check function - Remove what should be a redundant install, instead opt to fail if node is missing. Given that openaps-packages.sh handles installing node, this failing check indicates an unmitigated failure in the process previously, so let's not continue and make things potentially worse. - Attempt to remove existing nodejs/npm packages using apt - Warn the user if versions of node and npm remain - Switch nvm for n, using installed version of n if available Else, bootstrap install n as done elsewhere. * fix: Replace broken grep statements
This reverts commit 84f1011.
|
I guess I'd use wget to fetch a copy from GitHub directly.
…On Sun, Sep 18, 2022, 4:31 AM Scott Leibrand ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In bin/oref0-setup.sh
<#1433 (comment)>:
> @@ -1269,7 +1269,7 @@ if prompt_yn "" N; then
#Build Go binaries
#go get -u -v -tags "$radiotags" github.com/ecc1/medtronic/... || die "Couldn't go get medtronic"
go install -v -tags "$radiotags" ***@***.*** || die "Couldn't go get medtronic"
- ln -sf $HOME/go/src/github.com/ecc1/medtronic/cmd/pumphistory/openaps.jq $directory/ || die "Couldn't softlink openaps.jq"
+ ln -sf ***@***.***/cmd/pumphistory/openaps.jq $directory/ || die "Couldn't softlink openaps.jq"
@ecc1 <https://github.com/ecc1> This works, but looks fragile. What's the
proper way to do this now that go get is deprecated?
—
Reply to this email directly, view it on GitHub
<#1433 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALZHRO74EORHEPFGOD2DMTV63HPNANCNFSM5ZFUPWJA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This commit calls convert_bg on various console.error() print statements, which should improve readability for mmol/L users and leave mg/dL users' experience unaffected.
|
This should be ready for release now, to fix installs from master, unless anyone knows of any blockers. |
This reverts commit 80493da. This is causing future IOB predictions to be incorrect (highly negative). That causes the predBG lines to swoop up and to the right. That results in (slightly) too much insulin being dosed in some situations.
…lse mmtune (#1457) * on loop failure, retry preflight; if successful, refresh pumphistory, else mmtune * wait_for_silence before retrying preflight * need to return, not keep invoking fail() * only try preflight one more time before mmtuning
In some places a space is used instead of a colon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up for bug fixes and other updated for v0.7.2
The primary fix in this release is for:
Other fixes/improvements include:
TODO before release: