Support absolute mean for SONATA noise current clamp

[ilkilic]

Fix #54. Implements support for SONATA noise stimuli defined with mean (nA) in addition to mean_percent.

[codecov]

Codecov Report

❌ Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
bluecellulab/cell/injector.py	60.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
...ecellulab/stimulus/circuit_stimulus_definitions.py	77.82% <100.00%> (+0.96%)	⬆️
tests/test_circuit/test_simulation_config.py	100.00% <100.00%> (ø)
...test_stimulus/test_circuit_stimulus_definitions.py	100.00% <100.00%> (ø)
bluecellulab/cell/injector.py	94.80% <60.00%> (-0.81%)	⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[darshanmandge]

Thanks, @ilkilic.

I see in the documentation there is represents_physical_electrode. Maybe good to have it implemented if it possible. Also, does it exist for other stimuli?

[ilkilic]

We don't support represents_physical_electrode for any stimuli.

[ilkilic]

@darshanmandge Can we merge this fix first?

[darshanmandge]

Did you compare the responses of these new stimuli with those from neurodamus?

[ilkilic]

This is not a new stimulus and the underlying implementation hasn’t changed. The update only adds support for the SONATA absolute variant.

[darshanmandge]

This is not a new stimulus and the underlying implementation hasn’t changed. The update only adds support for the SONATA absolute variant.

I meant: if the soma and spike reports generated by this implementation in bluecellulab match those from neurodamus for the same stimuli applied?

[ilkilic]

We cannot properly compared with Neurodamus yet until this issue is solved

[darshanmandge]

Alright. Let's merge. Once you solve the related issue you can come back and check all the SONATA stimuli including these ones.