Skip to content

Seclamp stimulus#62

Merged
AurelienJaquier merged 8 commits intomainfrom
seclamp
Feb 27, 2026
Merged

Seclamp stimulus#62
AurelienJaquier merged 8 commits intomainfrom
seclamp

Conversation

@AurelienJaquier
Copy link
Collaborator

New seclamp stimulus following latest SONATA standards.

@AurelienJaquier AurelienJaquier self-assigned this Feb 13, 2026
@AurelienJaquier AurelienJaquier marked this pull request as ready for review February 13, 2026 15:26
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
bluecellulab/cell/injector.py 85.71% 2 Missing ⚠️
...ecellulab/stimulus/circuit_stimulus_definitions.py 84.61% 2 Missing ⚠️
bluecellulab/circuit_simulation.py 85.71% 1 Missing ⚠️
Files with missing lines Coverage Δ
tests/test_cell/test_injector.py 98.72% <100.00%> (+0.06%) ⬆️
...test_stimulus/test_circuit_stimulus_definitions.py 100.00% <ø> (ø)
bluecellulab/circuit_simulation.py 85.38% <85.71%> (-1.13%) ⬇️
bluecellulab/cell/injector.py 94.21% <85.71%> (-1.40%) ⬇️
...ecellulab/stimulus/circuit_stimulus_definitions.py 78.00% <84.61%> (+1.14%) ⬆️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AurelienJaquier
Copy link
Collaborator Author

for reference:
sonata latest standards: openbraininstitute/sonata-extension#20
neurodamus impementation: openbraininstitute/neurodamus#481

@AurelienJaquier
Copy link
Collaborator Author

@ilkilic please do not forget to review when you have some time ;)

Comment on lines +563 to +565
stimulus.duration,
stimulus.voltage,
stimulus.durations,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is stimulus.duration coming from if the user does not use SONATA simulation config for injection?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The argument names are very similar, stimulus.duration and stimulus.durations. Below, you use delay=stimulus_entry["delay"],. Could the first be renamed to stimulus.delay?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the initial delay fixed across all the steps?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • SEClamp expects duration. User has to give it, SONATA or otherwise.
  • duration and delay are two different things. duration is the total duration of the stimulus, i.e. the time during which the clamp is active. delay is actually not used but is needed, as stated in SONATA, mainly for backwards compatibility and consistency across stimuli.
  • there is no initial delay, the clamp is always active at t=0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thanks.

@AurelienJaquier AurelienJaquier merged commit 1db4898 into main Feb 27, 2026
7 of 8 checks passed
@AurelienJaquier AurelienJaquier deleted the seclamp branch February 27, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants