Conversation
Codecov Report❌ Patch coverage is
... and 17 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
for reference: |
|
@ilkilic please do not forget to review when you have some time ;) |
| stimulus.duration, | ||
| stimulus.voltage, | ||
| stimulus.durations, |
There was a problem hiding this comment.
Where is stimulus.duration coming from if the user does not use SONATA simulation config for injection?
There was a problem hiding this comment.
The argument names are very similar, stimulus.duration and stimulus.durations. Below, you use delay=stimulus_entry["delay"],. Could the first be renamed to stimulus.delay?
There was a problem hiding this comment.
Is the initial delay fixed across all the steps?
There was a problem hiding this comment.
- SEClamp expects duration. User has to give it, SONATA or otherwise.
- duration and delay are two different things. duration is the total duration of the stimulus, i.e. the time during which the clamp is active. delay is actually not used but is needed, as stated in SONATA, mainly for backwards compatibility and consistency across stimuli.
- there is no initial delay, the clamp is always active at t=0
New seclamp stimulus following latest SONATA standards.