Skip to content

make locale handling more portable#12

Open
mgeplf wants to merge 2 commits intomasterfrom
portable-locale
Open

make locale handling more portable#12
mgeplf wants to merge 2 commits intomasterfrom
portable-locale

Conversation

@mgeplf
Copy link
Collaborator

@mgeplf mgeplf commented Jun 30, 2025

  • don't save the local; change to std::locale("C") at the entrypoint of portions of the code that require a certain locale, using a scoped object

* don't save the local; change to `std::locale("C")` at the entrypoint
  of portions of the code that require a certain locale, using a scoped
  object
@coveralls
Copy link

coveralls commented Jun 30, 2025

Pull Request Test Coverage Report for Build 15972021993

Details

  • 25 of 27 (92.59%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 77.258%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/readers/utils.h 20 22 90.91%
Totals Coverage Status
Change from base Build 15847694722: 0.01%
Covered Lines: 2215
Relevant Lines: 2867

💛 - Coveralls

@mgeplf
Copy link
Collaborator Author

mgeplf commented Jun 30, 2025

I checked the performance, there is only a small difference:

-----------------------------------------------------------------------
Benchmark                             Time             CPU   Iterations
-----------------------------------------------------------------------
BM_load_morphology/asc             6.91 ms         6.91 ms          101
BM_load_morphology/swc             3.48 ms         3.48 ms          201
BM_load_morphology/swc             3.50 ms         3.49 ms          201

BM_load_morphology/asc             6.74 ms         6.74 ms          104
BM_load_morphology/swc             3.50 ms         3.50 ms          200
BM_load_morphology/swc             3.51 ms         3.50 ms          200

With files that are sized:

62872 neuron.asc
68332 neuron.swc
68395 neuron-ordered.swc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants