Skip to content

CHAT Embed plots in chat#1424

Merged
BoBer78 merged 36 commits intomainfrom
embed_plots_in_chat
Mar 9, 2026
Merged

CHAT Embed plots in chat#1424
BoBer78 merged 36 commits intomainfrom
embed_plots_in_chat

Conversation

@BoBer78
Copy link
Contributor

@BoBer78 BoBer78 commented Feb 18, 2026

closes https://github.com/openbraininstitute/prod-explore-functionality/issues/451
And since I branched out of @WonderPG's branch, also includes the changes from https://github.com/openbraininstitute/prod-ai/issues/18

Plots

Plots are now shown in chat and can be full-screened.
image

Backup

When the LLM messes up we have a small message in the chat (if the link is wrong) :
image

Then EVERY plot that was not mentioned and displayed in the LLM text will appear below the LLM summary, as a backup :
image

@github-actions
Copy link

github-actions bot commented Feb 18, 2026

Preview Deployment

Branch Status Preview Updated
embed_plots_in_chat ❌ Deleted - Mar 9, 2026 at 2:53 PM (UTC)

@BoBer78 BoBer78 changed the title Embed plots in chat CHAT Embed plots in chat Feb 18, 2026
@BoBer78 BoBer78 marked this pull request as ready for review February 18, 2026 14:51
@pgetta pgetta changed the base branch from develop to main February 26, 2026 08:08
@ayimaok
Copy link

ayimaok commented Feb 27, 2026

@BoBer78,

  1. When the ai panel is in its smallest size - the fullscreen button is not visible, if the title is long.
  2. This particular plot - looks 'folded' :)
image

in it's full size:
image

  1. prob, unrelated to the above - the long text outside of the viewport (we should have a ticket for this somewhere).
image
  1. In this PREVIEW env, if I click on the "View morphology details" - should it redirect to the detail page? Now it redirects to Invalid parameter:redirect_uri
image

URL: https://staging.cell-a.openbraininstitute.org/auth/realms/SBO/protocol/openid-connect/auth?client_id=core-webapp-cell-b-azure-staging&scope=profile%20openid%20groups&response_type=code&redirect_uri=https%3A%2F%2Fstaging.cell-a.openbraininstitute.org%2Fapi%2Fauth%2Fcallback%2Fkeycloak&state=yn5LJOT6Kp3aTB2Rj32717PWuxhqQnDP2zaZDNvjQeM&code_challenge=yu5AGPJuQ4HyPM-KluYWIajUflFIe7DlTcu6SQILaFE&code_challenge_method=S256

  1. It somehow generated an empty plot, maybe my prompt had not enough or no relevant info for it?
    (It's a continuation of the previous query: Show me the plot for that morphology,
    ad38bc54-3348-45e4-98d9-750cc5532927)
image
  1. The last screenshot (promise)
image

In full screen looks good.
image

@BoBer78
Copy link
Contributor Author

BoBer78 commented Mar 2, 2026

Thanks a lot @ayimaok for testing !
Let me reply to the "obvious" ones :

  1. The button is behind the text right ? Or there is something else ?
image

--> I will fix it.

  1. I will try to reduce the margin. But the chat being small is not really compatible with high detail plots.

  2. I never saw that, I doubt that my PR is the problem. I added overflow-x: hidden --> should be fixed now

  3. Not related to this PR, I guess this is an issue of the preview environement, works on localhost.

  4. That is very strange ... maybe there is a plot error, hard to say if the LLM failed to plot something relevant. Can I get more information ?

  5. Similar as number 2. --> Will try to reduce margin.

Unrelated found issue, when we resize the window, or the scale the chat, the plots are not responsive since they are memoised.
Feel free to contest any of the points !

@ayimaok
Copy link

ayimaok commented Mar 2, 2026

thanks for replying to all my questions @BoBer78.

Unrelated found issue, when we resize the window, or the scale the chat, the plots are not responsive since they are memoised.

Yes, I've transferred the ticket previously opened for this issue to the AI repo.

Please let me know when it's ready to be reviewed, I can re-test the issues raised in my comment. Thank you!

@BoBer78
Copy link
Contributor Author

BoBer78 commented Mar 2, 2026

@ayimaok
Should be ready to re-review, probably some edge cases that will not work, but overall I fixed all the main points

Copy link
Contributor

@jankrepl jankrepl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:) Thank you @BoBer78

@jdcourcol
Copy link
Contributor

Can this be in preview ? I think it is blocking another PR from @WonderPG .

@BoBer78
Copy link
Contributor Author

BoBer78 commented Mar 9, 2026

You mean preview main @jdcourcol ?
It should be merged today

@BoBer78 BoBer78 merged commit 95a70ee into main Mar 9, 2026
7 checks passed
@BoBer78 BoBer78 deleted the embed_plots_in_chat branch March 9, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants