Skip to content

improve activation time constant feature#8

Merged
AurelienJaquier merged 5 commits intomasterfrom
act-tau
Jul 9, 2025
Merged

improve activation time constant feature#8
AurelienJaquier merged 5 commits intomasterfrom
act-tau

Conversation

@AurelienJaquier
Copy link
Collaborator

@AurelienJaquier AurelienJaquier commented Jul 8, 2025

Description

  • when the time interval is empty, return a vlaue of 0 ms instead of the default value of 1 from curve_fit
  • make time interval and voltage interval start at the min voltage value. Motivation: some traces can have a artefact of rising voltage at the injection time. To avoid taking that into the fit, we should take the min value after the artefact
  • some fit fail and return a very big return value. Detect them when they are more than 10 times the duration of the interval and return the interval duration instead. It is not perfect, but will still induce less bias if this value is used later on.

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@AurelienJaquier AurelienJaquier self-assigned this Jul 8, 2025
@AurelienJaquier AurelienJaquier requested a review from ilkilic July 9, 2025 07:23
@AurelienJaquier AurelienJaquier merged commit 3f79736 into master Jul 9, 2025
21 checks passed
@AurelienJaquier AurelienJaquier deleted the act-tau branch July 9, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants