Skip to content

Add generic campaign and config related activities#532

Open
GianlucaFicarelli wants to merge 18 commits intomainfrom
generic_campaign
Open

Add generic campaign and config related activities#532
GianlucaFicarelli wants to merge 18 commits intomainfrom
generic_campaign

Conversation

@GianlucaFicarelli
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 99.13420% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
app/queries/utils.py 90.24% 2 Missing and 2 partials ⚠️
Flag Coverage Δ
pytest 97.95% <99.13%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/db/auth.py 95.00% <100.00%> (+8.88%) ⬆️
app/db/model.py 99.12% <100.00%> (+0.03%) ⬆️
app/db/triggers.py 100.00% <ø> (ø)
app/db/types.py 99.43% <100.00%> (+0.01%) ⬆️
app/filters/campaign.py 100.00% <100.00%> (ø)
app/filters/task_config.py 100.00% <100.00%> (ø)
app/filters/task_config_generation.py 100.00% <100.00%> (ø)
app/filters/task_execution.py 100.00% <100.00%> (ø)
app/queries/common.py 97.94% <100.00%> (-0.15%) ⬇️
app/queries/constants.py 100.00% <100.00%> (ø)
... and 17 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GianlucaFicarelli GianlucaFicarelli marked this pull request as ready for review February 27, 2026 17:14
@GianlucaFicarelli
Copy link
Collaborator Author

I'll add an additional test for updating nested relationships, but the changes can be reviewed.
However, I'm considering a separate PR for discussion based on this one, with only TaskConfig and TaskActivity, that can replace the classes added in this PR as the following:

  • Campaign -> TaskConfig[xxx__campaign]
  • TaskConfig -> TaskConfig[xxx__config]
  • TaskConfigGeneration -> TaskActivity[xxx__config_generation]
  • TaskExecution -> TaskActivity[xxx__execution]

where:

task_config_type (enum):

  • circuit_simulation__campaign
  • circuit_simulation__config
    ...

task_activity_type (enum):

  • circuit_simulation__config_generation
  • circuit_simulation__execution
    ...

This would allow to define workflows of task_config with more than 2 activities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant