Repository navigation
fix(aot): retain host evaluators only through reachable calls - #52
Merged
vincentkoc merged 2 commits intoNov 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a program evaluates text,
runUnseenCodetreats everyEvaluatesTextbuiltin as called. This also retains private Bun host evaluators that unseen JavaScript cannot name, keeping internal testing support in compiled programs.Change
Limit implicit evaluator roots to engine builtins. Reachable host calls still use the existing call/event analysis and keep truthful evaluator metadata.
Qualification adds two real Bun-host IR regressions from immutable Bun source
02526c26fb9cbf76c9748e9ed3ae67020d99dd77, verifies their SHA-256 digests, and runs the existing native control for all five language evaluators. The frozen Bun consumer, compiled inputs and existing qualification gates remain unchanged. Matching test programs come from the existing Ninja graph. Release notes describe the corrected behavior.Validation
75a16eef9d7a0f54946ec2e004f410924d1015c9passes Linux native, Windows ARM64 build/native qualification and macOS cross-build, plus Linux ARM64.2 passed, 0 failed, 0 todo, andclosed-world/evaluation/program-that-evaluates-text-keeps-every-evaluatorwith1 passed, 0 failed, 0 todo.7bf742934b5a72aefaac2dcd993e20d6b0e388c5through75a16eef9d7a0f54946ec2e004f410924d1015c9found no actionable correctness or security defects. Independent engine, qualification and release-note reviews also pass.Upstream source-only draft: oven-sh#998. Native execution of that exact upstream-base commit remains pending.
Part of openclaw/bun#221. Production delta: 3 additions/1 deletion; qualification: 25 additions using existing tools and test owners. This source PR includes no artifact publication or Bun pin change. Native Darwin consumer qualification remains a gate of a separately approved artifact publication.