feat(capabilities): Initial capability manifest support (legacy + map)#545
feat(capabilities): Initial capability manifest support (legacy + map)#545vincentkoc wants to merge 14 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2a524e9 to
446be4b
Compare
|
Refinement pass completed on schema/API branch. Updates added:
Local validation:
Note: current failing "Scan for Verified Secrets" check appears infrastructure-related (missing |
Greptile SummaryAdds capability manifest support to the skill registry, enabling skills to declare their required capabilities (shell, filesystem, network, browser, sessions, messaging, scheduling) for visibility and future enforcement. Key changes:
Implementation highlights:
Confidence Score: 4/5
Last reviewed commit: e0d4948 |
packages/schema/src/schemas.ts
Outdated
| latestVersion: type({ | ||
| version: 'string', | ||
| createdAt: 'number', | ||
| changelog: 'string', | ||
| capabilities: '("shell"|"filesystem"|"network"|"browser"|"sessions"|"messaging"|"scheduling")[]?', | ||
| }).optional(), |
There was a problem hiding this comment.
inconsistent indentation (should be 4 spaces like other fields, not 6)
| latestVersion: type({ | |
| version: 'string', | |
| createdAt: 'number', | |
| changelog: 'string', | |
| capabilities: '("shell"|"filesystem"|"network"|"browser"|"sessions"|"messaging"|"scheduling")[]?', | |
| }).optional(), | |
| latestVersion: type({ | |
| version: 'string', | |
| createdAt: 'number', | |
| changelog: 'string', | |
| capabilities: '("shell"|"filesystem"|"network"|"browser"|"sessions"|"messaging"|"scheduling")[]?', | |
| }).optional(), |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/schema/src/schemas.ts
Line: 170-175
Comment:
inconsistent indentation (should be 4 spaces like other fields, not 6)
```suggestion
latestVersion: type({
version: 'string',
createdAt: 'number',
changelog: 'string',
capabilities: '("shell"|"filesystem"|"network"|"browser"|"sessions"|"messaging"|"scheduling")[]?',
}).optional(),
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
Addressed in 6248053. Indentation has been normalized to match surrounding schema fields.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da1dab3ec8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
convex/lib/skills.ts
Outdated
| if (typeof clawdisObj.author === 'string') metadata.author = clawdisObj.author | ||
| const links = parseSkillLinks(clawdisObj.links) | ||
| if (links) metadata.links = links | ||
| const capabilities = normalizeCapabilities(clawdisObj.capabilities) |
There was a problem hiding this comment.
Read openclaw capabilities even when clawdis metadata exists
This normalization only reads clawdisObj.capabilities, and clawdisObj comes from the first metadata alias selected earlier (clawdbot/clawdis before openclaw). In mixed manifests that keep legacy metadata.clawdis fields but add new metadata.openclaw.capabilities (the format documented in this PR), the declared capabilities are silently dropped, so downstream API consumers see [] instead of the author-declared capabilities.
Useful? React with 👍 / 👎.
|
Addressed remaining review items from bots/reviewers in latest push:
Re-ran local validation after these updates:
|
Summary
Testing
bun run lintbun run testbun run buildRelated