Skip to content

test(search): add soft-delete filtering tests (#29)#552

Open
MunemHashmi wants to merge 1 commit intoopenclaw:mainfrom
MunemHashmi:test/29-search-soft-delete-filtering
Open

test(search): add soft-delete filtering tests (#29)#552
MunemHashmi wants to merge 1 commit intoopenclaw:mainfrom
MunemHashmi:test/29-search-soft-delete-filtering

Conversation

@MunemHashmi
Copy link

@MunemHashmi MunemHashmi commented Feb 27, 2026

Closes #29

Summary

  • Add test verifying soft-deleted skills are excluded from vector search hydration (hydrateResults)
  • Add test verifying soft-deleted exact slug matches are excluded from lexical fallback (lexicalFallbackSkills)

Test plan

  • All 12 search tests pass
  • Lint clean

…paths (openclaw#29)

Verify that soft-deleted skills are excluded from both vector search
hydration and lexical fallback exact-slug matching.
@vercel
Copy link
Contributor

vercel bot commented Feb 27, 2026

@MunemHashmi is attempting to deploy a commit to the Amantus Machina Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

Adds comprehensive test coverage for soft-delete filtering in search functionality. The two new test cases verify that soft-deleted skills are correctly excluded from both vector search hydration and lexical fallback exact slug matches, aligning with the existing implementation in convex/search.ts:229 and convex/search.ts:269.

The tests follow established patterns in the file, use appropriate mocks, and have clear assertions. All 12 tests reportedly pass, and the changes are purely additive (no modifications to existing tests or implementation code).

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects that this is a test-only change with no modifications to production code. The new tests correctly verify existing soft-delete filtering behavior, follow established testing patterns, and add valuable coverage for an important edge case. The PR author confirmed all tests pass and lint is clean.
  • No files require special attention

Last reviewed commit: 2b50e96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests: Search Results

1 participant