fix(ci): add job timeouts and pin dashboard checkout credentials - #1
Merged
steipete merged 2 commits intoSep 14, 2026
Merged
Conversation
SebTardif
marked this pull request as ready for review
September 8, 2026 00:38
Set timeout-minutes on dashboard (20) and CI (10). Stop persisting checkout credentials on the contents:write dashboard job and push README updates with an explicit GITHUB_TOKEN URL. Signed-off-by: Sebastien Tardif <SebTardif@ncf.ca>
steipete
force-pushed
the
fix/workflow-timeouts-and-checkout-creds
branch
from
September 14, 2026 19:26
cef0636 to
98e1bb7
Compare
|
Landed as 64b4a3e with your timeout and credential changes, rebased onto current main. During landing I also made the dashboard checkout shallow: a prior successful full-history run took over 20 minutes, while the post-merge dashboard run completed in 20 seconds. Added the Unreleased changelog entry and preserved co-author credit. All 48 tests, workflow lint, functional publishing/materializer checks, independent review, and exact-head CI passed. Thanks @SebTardif! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI and dashboard jobs previously relied on GitHub's six-hour default timeout, and the dashboard persisted its write credentials in both checkouts. Bound CI to 10 minutes and dashboard generation to 20 minutes, disable credential persistence in both dashboard checkouts, and supply the token only for publishing the generated README.
During landing, change the dashboard's main checkout to depth 1: successful run 34877005730 spent 19m55s fetching full history and took over 20 minutes overall. The renderer and README-only commit require no history. Add an Unreleased changelog entry thanking @SebTardif.
Validation: frozen pnpm install; all 48 tests; actionlint including shellcheck; whitespace checks; real rendering from a fresh state-branch snapshot with deterministic repeat output; materializer and renderer invocation with a validated synthetic ledger event; extracted publishing script exercised against a disposable shallow Git repository, including README-only push and unchanged-run behavior.