fix(windows): resolve platform shell instead of hardcoding /bin/sh#22
Open
arosstale wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(windows): resolve platform shell instead of hardcoding /bin/sh#22arosstale wants to merge 1 commit intoopenclaw:mainfrom
arosstale wants to merge 1 commit intoopenclaw:mainfrom
Conversation
All exec paths hardcode /bin/sh which doesn't exist on Windows, causing ENOENT on every shell command. This adds a resolveShell() helper that returns cmd.exe on win32 and /bin/sh elsewhere. Fixes spawn ENOENT on Windows for: - exec --shell commands - SDK exec() with shell:true - Workflow file step execution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All shell execution paths hardcode
/bin/shwhich doesn't exist on Windows, causingspawn ENOENTon every shell command.What broke
On Windows, any command using
--shell, SDKexec()withshell:true, or workflow file steps throws:How the fix works
Added
src/shell.tswith aresolveShell(command)helper that returns:['cmd.exe', ['/s', '/c', command]]on win32['/bin/sh', ['-lc', command]]elsewhereUpdated 3 call sites:
src/commands/stdlib/exec.tssrc/sdk/primitives/exec.tssrc/workflows/file.tsTesting
printfand single-quotednode -e)[AI-assisted]