fix: add A2UI bundle step to gateway test build#65
Closed
arubis wants to merge 1 commit intoopenclaw:mainfrom
Closed
fix: add A2UI bundle step to gateway test build#65arubis wants to merge 1 commit intoopenclaw:mainfrom
arubis wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Upstream renamed server.canvas-auth.e2e.test.ts to .test.ts (commit 2dcb2449), bringing it into the gateway vitest suite for the first time. The test expects A2UI assets on disk, but the test build never ran canvas:a2ui:bundle — causing a 503 instead of the expected 200. Add the minimal build steps needed to produce the bundle: native dep rebuild, rolldown PATH shim (same pattern as the production build), and the canvas:a2ui:bundle step itself. Closes openclaw#64 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 24, 2026
Author
|
Folded into #63 — the two fixes are tightly coupled (the test build fix is only needed because of the pin bump, and the pin bump can't pass CI without the test build fix). Keeping them in one PR avoids a chicken-and-egg CI problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there — first-time contributor here. We ran into this while working on #62 (the rolldown/sandbox build fix in #63). Happy to adjust anything that doesn't fit your preferences.
Problem
Upstream commit
2dcb2449("refactor(test): dedupe gateway and web scaffolding") renamedserver.canvas-auth.e2e.test.tstoserver.canvas-auth.test.ts. The vitest base config excludes**/*.e2e.test.ts, so this rename brought the canvas-auth test into the gateway vitest suite for the first time.The test expects a scoped A2UI fetch to return HTTP 200, but
gateway-tests-build.shonly ranpnpm install— it never produceda2ui.bundle.js. Without the bundle, the A2UI handler returns 503 ("A2UI assets not found"), causing the test to fail.Fix
Add the minimal build steps needed to produce the A2UI bundle in the test environment:
chmod -R u+w node_modules(required forpnpm rebuild)pnpm rebuildfor native deps (same download-blocker pattern as the production build)rolldown-plugin-dts)pnpm canvas:a2ui:bundleThe STDENV_SETUP check is also moved earlier in the script to match the production build's ordering.
Verification
.e2e.test.tsat that versionCloses #64
Test plan
nix build .#checks.x86_64-linux.gateway-testspasses at v2026.2.22 — 54 test files, 553 tests, all greennix build .#checks.x86_64-linux.gateway-testsat v2026.2.20 — no regression from this change (pre-existingnet.test.tsfailure unrelated)🤖 Generated with Claude Code