Skip to content

fix: improve script safety and clarity in path and temp handling #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve script safety and clarity in path and temp handling #142

wants to merge 1 commit into from
+46 −48

Conversation

appleboy
Copy link

@appleboy appleboy commented May 2, 2025 •
edited
Loading

  • Remove unnecessary blank lines for improved script clarity
  • Replace hardcoded temp directory with mktemp for safer temporary file creation during download
  • Fix logic to correctly detect if INSTALL_DIR is already in PATH and prevent duplicate PATH entries
  • Print a message when INSTALL_DIR is already present in PATH

@appleboy
fix: improve script safety and clarity in path and temp handling
f4367e8 
- Remove unnecessary blank lines for improved script clarity
- Replace hardcoded temp directory with mktemp for safer temporary file creation during download
- Fix logic to correctly detect if INSTALL_DIR is already in PATH and prevent duplicate PATH entries
- Print a message when INSTALL_DIR is already present in PATH

Signed-off-by: appleboy <[email protected]>
@appleboy appleboy changed the title refactor: refactor installer script for maintainability and robustness fix: improve script safety and clarity in path and temp handling May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@appleboy