This repository was archived by the owner on Jul 29, 2025. It is now read-only.
fix: improve script safety and clarity in path and temp handling #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary blank lines for improved script clarity - Replace hardcoded temp directory with mktemp for safer temporary file creation during download - Fix logic to correctly detect if INSTALL_DIR is already in PATH and prevent duplicate PATH entries - Print a message when INSTALL_DIR is already present in PATH Signed-off-by: appleboy <[email protected]>
appleboy
changed the title
|
@kujtimiihoxha any feedback? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.