Update test_hdf5.cpp #3294
Open
Update test_hdf5.cpp #3294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a unique filename (via std::tmpnam) for test. Allows unit test to be run in environments where the current working directory is not writable.
asmorkalov
reviewed
Aug 8, 2022
| @@ -15,7 +17,7 @@ struct HDF5_Test : public testing::Test | |||
| { | |||
| virtual void SetUp() | |||
| { | |||
| m_filename = "test.h5"; | |||
| m_filename = std::tmpnam(nullptr) + "_test.h5"; | |||
There was a problem hiding this comment.
It's recommended to use cv::tempfile for tests: https://docs.opencv.org/4.x/db/de0/group__core__utils.html#ga9fcedbe6d0104d7ce012987478b060d4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a unique filename (via std::tmpnam) for test. Allows unit test to be run in environments where the current working directory is not writable.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.