ximgproc: GraphSegmentation: support CV_8U/CV_8S/CV_16U/CV_16S/CV_32F/CV_64F input #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kumataro
changed the title
Kumataro
changed the title
| make_tuple<int, double, int>( CV_32SC1, 2147483647. / 255., 14 ), | ||
| make_tuple<int, double, int>( CV_32SC2, 2147483647. / 255., 17 ), | ||
| make_tuple<int, double, int>( CV_32SC3, 2147483647. / 255., 17 ), | ||
| make_tuple<int, double, int>( CV_32SC4, 2147483647. / 255., 17 ), |
There was a problem hiding this comment.
32S/U and 64S/U are not used to store images.
The same is for bool, BF16.
FP16 is should be omitted too (8U do that better with less memory).
8U/16U/32F - this is the primary list to work with images.
There was a problem hiding this comment.
Thank you for your review! I see and remove supporing CV_32SCs (implementation, test and document).
Kumataro
changed the title
|
Building has been started yesterday, but there are 2 warnings. They will be fixed by opencv/opencv#24512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3544
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.