Skip to content

RHAIENG-287: fix(kustomization.yaml): abbreviate namePrefix to resolve Kubernetes label character limit issue #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RHAIENG-287: fix(kustomization.yaml): abbreviate namePrefix to resolve Kubernetes label character limit issue #2620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion jupyter/pytorch+llmcompressor/ubi9-python-3.12/kustomize/base/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namePrefix: jupyter-pytorch-llmcompressor-ubi9-python-3-12-
# have to abbreviate the prefix, otherwise we'd go over the 63 character limit
# > Pod "jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-0" is invalid: metadata.labels: Invalid value: "jupyter-pytorch-llmcompressor-ubi9-python-3-12-notebook-7d69c59fc6": must be no more than 63 characters
namePrefix: jupyter-pt-llmcompress-ubi9-python-3-12-
labels:
- includeSelectors: true
pairs:
Expand Down
5 changes: 5 additions & 0 deletions scripts/test_jupyter_with_papermill.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,9 @@ function _get_notebook_id() {
*${jupyter_pytorch_notebook_id}-*)
notebook_id="${accelerator:+$accelerator/}${jupyter_pytorch_notebook_id}"
;;
*${jupyter_pytorch_llmcompressor_notebook_shortened_id}-*)
notebook_id="${accelerator:+$accelerator/}${jupyter_pytorch_llmcompressor_notebook_full_id}"
;;
*)
printf '%s\n' "No matching condition found for ${notebook_workload_name}."
exit 1
Expand Down Expand Up @@ -387,6 +390,8 @@ jupyter_datascience_notebook_id='datascience'
jupyter_trustyai_notebook_id='trustyai'
jupyter_pytorch_notebook_id='pytorch'
jupyter_tensorflow_notebook_id='tensorflow'
jupyter_pytorch_llmcompressor_notebook_shortened_id='pt-llmcompress'
jupyter_pytorch_llmcompressor_notebook_full_id="pytorch-llmcompressor"

notebook_name=$( _get_notebook_name "${test_target}" )
python_flavor="python-${test_target//*-python-/}" # <-- python-3.11
Expand Down
Loading