feat: add SAML provider admin viewsets to enterprise API#2550
Draft
feat: add SAML provider admin viewsets to enterprise API#2550
Conversation
pwnage101
commented
Mar 5, 2026
Comment on lines
+29
to
+32
| def _get_tpa_classes(self): | ||
| # Deferred import — TPA models live in openedx-platform. | ||
| from common.djangoapps.third_party_auth.models import SAMLProviderConfig # pylint: disable=import-outside-toplevel | ||
| from common.djangoapps.third_party_auth.samlproviderconfig.serializers import SAMLProviderConfigSerializer # pylint: disable=import-outside-toplevel |
Contributor
Author
There was a problem hiding this comment.
We might just have to re-evaluate this whole approach because we don't want the view to import a bunch of modules from openedx-platform, which would have unit test implications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENT-11567
Related: