import FooterSlot from frontend-slot-footer package#1109
Open
hinakhadim wants to merge 2 commits intoopenedx:open-release/redwood.masterfrom
Open
import FooterSlot from frontend-slot-footer package#1109hinakhadim wants to merge 2 commits intoopenedx:open-release/redwood.masterfrom
hinakhadim wants to merge 2 commits intoopenedx:open-release/redwood.masterfrom
Conversation
The previous version of `frontend-slot-footer` had a peer dependency of `^14.0.0`, which caused problems for some methods of installing forked footers. This updates to a version of `frontend-slot-footer` that allows for *any* version of `frontend-component-footer` in the peer dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR of #1048 and #1050
Issue:
Account MFE generates an error when custom footer is installed and Other MFEs are working fine with the same footer. The problem is that Account MFE is not importing the footer from "fronted-slot-footer" package while other MFEs are doing so. This is resolved in
masterbranch of Account MFE but need to backport inopen-release/redwood.master.